chore(bridge-withdrawer, composer): encode submission payload only once #2053
+15
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed submission logic to only encode retried transaction submissions to bytes once.
Background
Previously, Bridge Withdrawer and Composer utilized
SequencerClientExt::submit_transaction_sync()
, which encodes the transaction to bytes within the method. Within a retry configuration, this unnecessarily performs the conversion each time. These changes eliminate these superfluous encodings in favor of retrying with the same bytes each time.Changes
submit_transaction_sync()
calls tobroadcast_tx_sync()
calls.Testing
Passing all tests, no additional ones needed since the functionality is the same.
Changelogs
No updates required.
Related Issues
closes #2050