Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): geth logLevel #2045

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

quasystaty1
Copy link
Contributor

Summary

adds verbosity flag to geth statefulset. The log level is set based on config.logLevel entry.
alternative approaches:

  • Setting config.logLevel to a numeric value (as expected by Geth) with documentation for users. This keeps the configuration simple and consistent with other flags but diverges from our other charts.
  • Templating the config value directly in values.yaml, which works but is not an ideal approach for maintainability.

Changes

  • adds a new flag configuring geth log level.

Testing

Tested against a local cluster

Changelogs

No updates required.

Verified

This commit was signed with the committer’s verified signature.
quasystaty1 quasystaty
@quasystaty1 quasystaty1 requested a review from a team as a code owner March 19, 2025 16:18
@quasystaty1 quasystaty1 requested a review from joroshiba March 19, 2025 16:18
@github-actions github-actions bot added the cd label Mar 19, 2025
@quasystaty1 quasystaty1 added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit c7becca Mar 19, 2025
48 checks passed
@quasystaty1 quasystaty1 deleted the quasystaty1/charts/rollup-loglevel branch March 19, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants