chore(sequencer): remove references to outdated ABCI methods #1826
+155
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
force-pushed
the
ENG-1006/begin_and_end_block
branch
from
cdda4c7 to
1662c72
Compare
ethanoroshiba
changed the title
noot
reviewed
Nov 21, 2024
github-actions
bot
added
documentation
ethanoroshiba
force-pushed
the
ENG-1006/begin_and_end_block
branch
from
8b10b28 to
0629d4f
Compare
ethanoroshiba
removed
documentation
|
tbh, I kind of liked the function names |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or this PR will be |
noot
reviewed
Mar 19, 2025
noot
reviewed
Mar 19, 2025
noot
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renamed
begin_blockandend_blockand replaced their arguments with our own types.Background
The ABCI methods
begin_blockandend_block, as well as their associated types, were removed as of v0.38. While it is useful for us to have start and end of block hooks for our components to make changes to the state, we should stop using outdated types.Changes
BeginBlockwith proprietary typePrepareStateInfo.EndBlockas an argument, since it was not needed.feescomponent.Testing
Passing all tests.
Changelogs
No updates needed, I don't think.
Related Issues
closes #1809