Provide snapshot tests for storage values in sequencer #1982
Assignees
Labels
Comments
Fraser999
added
sequencer
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 7, 2025
…te-breaking changes (#1985) ## Summary Added snapshot tests for all storage values to ensure that future changes do not break state. ## Background The addition of the `BridgeTransfer` action revealed how inserting a value into the storage `ValueImpl` is a breaking change, since deserialization would then fail. New values, such as `BridgeTransferFees` need to be appended instead of inserted. Adding snapshots for each storage variant's discriminant ensures that there is an extra level of protection against making a state breaking change. ## Changes - Added snapshots for the borsch encoding of every `ValueImpl` variant and every `StoredValue` variant. ## Testing Manually reviewed every discriminant. ## Changelogs No updates required. ## Related Issues closes #1982 --------- Co-authored-by: Jordan Oroshiba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to ensure new variants of the many
<component>::storage::ValueImplenums are only ever appended to the existing ones. Providing snapshot tests for every variant will help ensure this (as well as helping ensure existing variants don't change).We should also provide a snapshot test for each variant of the top-level
StoredValueenum too, for the same reasons.The text was updated successfully, but these errors were encountered: