Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for queries missing tests #1741

Closed
SuperFluffy opened this issue Oct 25, 2024 · 2 comments · Fixed by #1998
Closed

Add unit tests for queries missing tests #1741

SuperFluffy opened this issue Oct 25, 2024 · 2 comments · Fixed by #1998
Assignees
@noot
Labels
ignore-stale Override for issues or PRs which should not be removed if stale. sequencer pertaining to the astria-sequencer crate stale testing

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Oct 25, 2024 •
edited by sync-by-unito bot
Loading

The following PRs introduced queries, none of which provided unit tests for the query handling. They should be added.

#1158
#1189
#1196

┆Issue Number: ENG-951
@SuperFluffy SuperFluffy added the sequencer pertaining to the astria-sequencer crate label Oct 25, 2024
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@noot noot removed the stale label Dec 13, 2024
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@syedali012 syedali012 added the ignore-stale Override for issues or PRs which should not be removed if stale. label Jan 30, 2025
@noot noot mentioned this issue Feb 24, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 21, 2025
@noot
tests(sequencer): add unit tests for bridge_account_last_tx_hash an…
Loading
Loading status checks…
100319b 
…d `transaction_fee` ABCI queries (#1998)

## Summary
add unit tests for `bridge_account_last_tx_hash` and `transaction_fee`
ABCI queries

## Background
unit tests were missing for these functions.

## Changes
- add unit tests for `bridge_account_last_tx_hash` and `transaction_fee`
ABCI queries
- question: the `transaction_fee` query does not error if one of the
`fee_assets` is not an authorized fee asset in state. is this something
we want to check? is there a case where someone may want to calculate
the fee for an action but not use a currently authorized `fee_asset`?

## Testing
no code changes, just tests added.

## Related Issues

closes #1741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noot noot

Labels
ignore-stale Override for issues or PRs which should not be removed if stale. sequencer pertaining to the astria-sequencer crate stale testing
Projects
None yet
Milestone
No milestone
4 participants
@joroshiba @SuperFluffy @noot @syedali012