-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add 3 retries in uv publish
#12041
Open
konstin
wants to merge
3
commits into
main
Choose a base branch
from
konsti/fix-upload-retry-policy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the publish client, we have to set the client retries to 0 as the retry middleware is incompatible with upload bodies. This however also sets `client.retry_policy()` to a zero-retry policy, so we need to construct our own policy. Fixes #12027
zanieb
reviewed
Mar 7, 2025
zanieb
approved these changes
Mar 7, 2025
Co-authored-by: Zanie Blue <[email protected]>
Can you add a test plan that we can use to reproduce and test in the future? |
Even if it’s not an automated test, it’d be great to be able to look back here and know how to test this. |
I've used this script: # /// script
# requires-python = ">=3.12"
# dependencies = [
# "flask>=3.1.0,<4",
# ]
# ///
from argparse import ArgumentParser
from flask import Flask, app
app = Flask(__name__)
@app.route("/", defaults={"path": ""}, methods=["GET", "POST"])
@app.route("/<path:path>", methods=["GET", "POST"])
def always_error(path):
return "Internal Server Error", 500
def main():
app.run(debug=True, host="0.0.0.0", port=5000)
if __name__ == "__main__":
main() With released uv:
With this branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the publish client, we have to set the client retries to 0 as the retry middleware is incompatible with upload bodies. This however also sets
client.retry_policy()
to a zero-retry policy, so we need to construct our own policy.Fixes #12027