Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example for S611 #16316

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Fix example for S611 #16316

merged 1 commit into from
Feb 22, 2025
+1 −1

Conversation

aripollak
Copy link
Contributor

Summary

  • Existing example did not include RawSQL() call like it should
  • Also clarify the example a bit to make it clearer that the code is not secure

Test Plan

N/A, only documentation updated

@aripollak
Fix example for S611
aa82c85 
* Existing example did not include RawSQL() call like it should
* Also clarify the example a bit to make it clearer that the code is not secure
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre added the documentation Improvements or additions to documentation label Feb 22, 2025
ntBre
ntBre approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The example matches the rule tests now, which is great.

@ntBre ntBre merged commit aa88f2d into astral-sh:main Feb 22, 2025
21 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntBre ntBre ntBre approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aripollak @ntBre