Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Improved error message for attribute-assignments #15668

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[red-knot] Improved error message for attribute-assignments #15668

merged 2 commits into from
Jan 22, 2025

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Jan 22, 2025

Summary

Slightly improved error message for attribute assignments as per this suggestion.

Test Plan

—

@sharkdp sharkdp added the red-knot Multi-file analysis & type inference label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sharkdp sharkdp enabled auto-merge (squash) January 22, 2025 11:04
@sharkdp sharkdp merged commit 13e7afc into main Jan 22, 2025
20 checks passed
@sharkdp sharkdp deleted the david/attribute-assignment-improved-error branch January 22, 2025 11:04
@sharkdp sharkdp mentioned this pull request Jan 27, 2025
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkdp @AlexWaygood