fix: simplify env vars parsing #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrecloutier
changed the title
Stratus3D
reviewed
Feb 26, 2025
internal/execenv/execenv_test.go
Outdated
| env, err := Generate(plugin, map[string]string{"EQUALSTEST": "abc\n123"}) | ||
| assert.Nil(t, err) | ||
| assert.Equal(t, value, env["BAZ"]) | ||
| assert.Equal(t, "abc\n123", env["EQUALSTEST"]) |
There was a problem hiding this comment.
I think the EQUALSTEST code could be removed from this test as it's not really relevant and already converted by another t.Run.
Stratus3D
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Thanks for the PR @andrecloutier ! I left one comment, otherwise looks good to me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the parsing of env vars reported by bash by parsing NULL delimited values rather than new lines.
Fixes: #1986
Other Information