Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ONYX-1604): track progressive onboarding tooltips #11657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dariakoko
Copy link
Contributor

@dariakoko dariakoko commented Mar 12, 2025

This PR resolves ONYX-1604

Description

Track progressive onboarding tooltips
Track then visible

Partially relevant slack thread with Xander: https://artsy.slack.com/archives/C05EQL4R5N0/p1741116191231399

tracking event:

    action: ActionType.tooltipViewed;
    context_owner_type?: OwnerType;
    context_module: ContextModule
    type: string;

> NOTE: context_owner_type is optional and will be missing for the 'save-artwork' onboarding tooltip only. Adding it will require some prop drilling, data said it's fine, but I'm open to other opinions.

Some examples of the tracking event:

Alert create reminder Alert create Long Press
Simulator Screenshot - iPhone 16 Pro Max - 2025-03-12 at 11 41 27 Simulator Screenshot - iPhone 16 Pro Max - 2025-03-12 at 11 40 50 Simulator Screenshot - iPhone 16 Pro Max - 2025-03-12 at 11 38 56

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • track progressive onboarding tooltips

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (track progressive onboarding tooltips - dariakoko)

Generated by 🚫 dangerJS against 0cb8a6d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants