-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Team invites doc and user journey #1644
base: main
Are you sure you want to change the base?
Conversation
The preview deployment is in progress. 🟡 Last updated at: 2025-03-07 16:08:13 CET |
@@ -96,6 +96,10 @@ | |||
{ | |||
label: 'Verify user', | |||
href: '/docs/products/auth/verify-user' | |||
}, | |||
{ | |||
label: 'Manage team invites', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label: 'Manage team invites', | |
label: 'Manage team invites', |
Navigation labels should focus on nouns rather than verbs to maintain a consistent style. This ensures that all items in the navigation menu have the same tone and structure, making them easier to scan and understand quickly. For example, instead of “Manage team invites,” we would simply use “Team invites.”
By avoiding verbs like “Manage,” we eliminate the need to prefix every label with an action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On that note, we should probably also change Verify user
to User verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this back. I initially used "Team invites" but just updated it from a review above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eldadfux Done
Co-authored-by: Steven Nguyen <[email protected]>
|
||
// Create membership with email invite | ||
let membership = try await teams.createMembership( | ||
teamId: "team_id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
placeholders are still inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
What does this PR do?
Adds team invites doc and user journey
Test plan
/docs/products/auth/team-invites
Related
DRL-1114