Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Team invites doc and user journey #1644

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Conversation

ebenezerdon
Copy link
Contributor

What does this PR do?

Adds team invites doc and user journey

Test plan

  • Run the app and navigate to /docs/products/auth/team-invites
  • Verify content and that team invites is added as a new auth journey

Related

DRL-1114

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Jan 14, 2025

The preview deployment is in progress. 🟡

Open Build Logs

Last updated at: 2025-03-07 16:08:13 CET

@@ -96,6 +96,10 @@
{
label: 'Verify user',
href: '/docs/products/auth/verify-user'
},
{
label: 'Manage team invites',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: 'Manage team invites',
label: 'Manage team invites',

Navigation labels should focus on nouns rather than verbs to maintain a consistent style. This ensures that all items in the navigation menu have the same tone and structure, making them easier to scan and understand quickly. For example, instead of “Manage team invites,” we would simply use “Team invites.”

By avoiding verbs like “Manage,” we eliminate the need to prefix every label with an action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On that note, we should probably also change Verify user to User verification

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this back. I initially used "Team invites" but just updated it from a review above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldadfux Done

@ebenezerdon ebenezerdon requested a review from eldadfux January 28, 2025 21:43
@ebenezerdon ebenezerdon requested a review from stnguyen90 March 1, 2025 00:21

// Create membership with email invite
let membership = try await teams.createMembership(
teamId: "team_id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholders are still inconsistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ebenezerdon ebenezerdon requested a review from stnguyen90 March 7, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants