Fix: making mtcli's download to be platform and machine-aware and work for mac/darwin as well

[yashvardhan-kukreja]

Signed-off-by: Yashvardhan Kukreja [email protected]

Previously, sretoolbox used to Linux x86_64's mtcli binary irrespective of the underlying platform/architecture causing sretoolbox.binaries.mtcli to break when run on MacOS/Darwin.

The above PR fixes that by adding platform detection while cooking up the mtcli binary's download url ensuring that Darwin binary is downloaded when run on MacOS/Darwin and Linux binary is downloaded when run over Linux.

UPDATE regarding latest commit: raise an error instead of just returning None if there's any problem with download any child binary associated with sretoolbox. Will help catching potential binary-related execution's errors beforehand in runtime.

[sugarraysam]

The problem is that the mtcli binary is not cross-compiled anymore. We added a library, which requires building with CGO_ENABLED=1, which prevents cross-compilation as it uses C bindings that are proper to each platform.

We would need to run the build on a Darwin VM, and Windows VM to cross-compile.

Reference PR: mt-sre/addon-metadata-operator#18

[apahim]

we should probably just raise an exception if someone tries to get the binary in an unsupported platform. We don't even have to control the supported platforms here, just handle the HTTPError when reaching out to an download_url_template that doesn't exist.

[yashvardhan-kukreja]

The problem is that the mtcli binary is not cross-compiled anymore. We added a library, which requires building with CGO_ENABLED=1, which prevents cross-compilation as it uses C bindings that are proper to each platform.

We would need to run the build on a Darwin VM, and Windows VM to cross-compile.

Reference PR: mt-sre/addon-metadata-operator#18

Ahh, thanks for confirming this. I just took a look at the v0.1.0 and saw the binaries for Linux/Darwin amd64/arm64 compiled. But I guess from v0.2.0 onwards, only linux binaries are going to be compiled.

we should probably just raise an exception if someone tries to get the binary in an unsupported platform. We don't even have to control the supported platforms here, just handle the HTTPError when reaching out to an download_url_template that doesn't exist.

I guess, when asked for version 0.1.0, the sretoolbox.binaries.Mtcli library should download the mtcli binary w.r.t darwin/linux amd/arm, but for any other version, as you suggested, it can raise an HTTPError for any non-linux non-amd target.

How does that sound @sugarraysam @apahim :)