Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine some comments and naming in kubebuilderx #8991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Feb 28, 2025

Make it look better in rendered go doc html.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.07%. Comparing base (b5f15e0) to head (7e00b27).

Files with missing lines Patch % Lines
...oller/instanceset/reconciler_instance_alignment.go 0.00% 1 Missing ⚠️
...ntroller/instanceset/reconciler_revision_update.go 0.00% 1 Missing ⚠️
pkg/controller/instanceset/reconciler_update.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8991   +/-   ##
=======================================
  Coverage   60.06%   60.07%           
=======================================
  Files         390      390           
  Lines       46516    46518    +2     
=======================================
+ Hits        27942    27947    +5     
+ Misses      15886    15885    -1     
+ Partials     2688     2686    -2     
Flag Coverage Δ
unittests 60.07% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjc7373 cjc7373 marked this pull request as ready for review March 6, 2025 06:57
@cjc7373 cjc7373 requested a review from a team as a code owner March 6, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant