-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pause and resume reconciliation of a cluster #7435
Open
yipeng1030
wants to merge
28
commits into
apecloud:main
Choose a base branch
from
yipeng1030:featue/support_cluster_pause_and_resume
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6deb80e
wip
yipeng1030 a64cc39
support cluster pause and resume
yipeng1030 42d509e
merge from main
yipeng1030 94c6462
pause configuration as well
yipeng1030 4ed5dd5
Merge remote-tracking branch 'upstream/main'
yipeng1030 a89df33
Merge remote-tracking branch 'upstream/main' into featue/support_clus…
yipeng1030 25b85f6
merge from main and improve some implements
yipeng1030 e4e0740
tidy import order
yipeng1030 8466b1d
Merge remote-tracking branch 'upstream/main'
yipeng1030 46b47c8
Merge branch 'main' into featue/support_cluster_pause_and_resume
yipeng1030 1cc3982
merge from main
yipeng1030 a42ebcf
merge from main
yipeng1030 578967e
fix pr
yipeng1030 4aeae0f
fix pr
yipeng1030 5398f89
fix pr
yipeng1030 72f8e43
Merge branch 'featue/support_cluster_pause_and_resume' of github.com:…
yipeng1030 1a588d2
fix several reviews
yipeng1030 419c5ba
fix
yipeng1030 d730712
Merge remote-tracking branch 'upstream/main' into featue/support_clus…
yipeng1030 77908af
fix
yipeng1030 55b118d
fix
yipeng1030 ad1ac48
fix
yipeng1030 23b44dc
add ut
yipeng1030 59d0c45
fix
yipeng1030 cef893c
fix
yipeng1030 c5e8e34
pause back up as well
yipeng1030 5bc432a
fix typo
yipeng1030 f7b3b48
make code flatter
yipeng1030 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the pause and resume operations be executed before all transformers? According to your design, can a cluster that is being deleted be paused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deletion has a higher priority than pause in my design, which is refer to the design of rollout pause of the k8s deployment.