[MINOR][SQL][TESTS] Use formatString.format(value) instead of value.formatted(formatString)
#48262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.formatted(formatString)`
panbingkun
commented
Sep 26, 2024
| @@ -91,7 +91,7 @@ object CompressionSchemeBenchmark extends BenchmarkBase with AllCompressionSchem | |||
|
|
|||
| schemes.filter(_.supports(tpe)).foreach { scheme => | |||
| val (compressFunc, compressionRatio, buf) = prepareEncodeInternal(count, tpe, scheme, input) | |||
| val label = s"${getFormattedClassName(scheme)}(${compressionRatio.formatted("%.3f")})" | |||
There was a problem hiding this comment.
I accidentally discovered this while upgrading to scala 2.13.15.
I searched the Spark repo and found that this mode (value. formatted(formatString)) was only used here.
LuciferYang
approved these changes
Sep 26, 2024
|
Merged into master. Thanks @panbingkun |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…e.formatted(formatString)` ### What changes were proposed in this pull request? The pr aims to use `formatString.format(value)` instead of `value.formatted(formatString)` for eliminating Warning. ### Why are the changes needed? <img width="876" alt="image" src="https://github.com/user-attachments/assets/0e5798f4-ec53-41f7-aba9-8f8e51347f59"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48262 from panbingkun/minor_formatted. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…e.formatted(formatString)` ### What changes were proposed in this pull request? The pr aims to use `formatString.format(value)` instead of `value.formatted(formatString)` for eliminating Warning. ### Why are the changes needed? <img width="876" alt="image" src="https://github.com/user-attachments/assets/0e5798f4-ec53-41f7-aba9-8f8e51347f59"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48262 from panbingkun/minor_formatted. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to use
formatString.format(value)instead ofvalue.formatted(formatString)for eliminating Warning.Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.