Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Replace printStacktrace() with Debug.logXXX (OFBIZ-13214) #880

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Improved: Replace printStacktrace() with Debug.logXXX (OFBIZ-13214) #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .../src/main/java/org/apache/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,6 @@ private static void initializeTransactionProcessor() {
tp = new TransactionProcessor();
} catch (InitializationException iex) {
Debug.logError("TransactionProcessor failed to initialize" + iex.getMessage(), MODULE);
iex.printStackTrace();
}
}

Expand All @@ -498,7 +497,6 @@ private static Map<String, Object> processCard(RequestIF request) {
processCardResult.put("processCardResponse", response);
} catch (TransactionException tex) {
Debug.logError("TransactionProcessor failed to initialize" + tex.getMessage(), MODULE);
tex.printStackTrace();
}
processCardResult.put(ModelService.RESPONSE_MESSAGE, ModelService.RESPOND_SUCCESS);
return processCardResult;
Expand Down
1 change: 0 additions & 1 deletion applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4953,7 +4953,6 @@ public Map<String, Object> createDropShipGroups(LocalDispatcher dispatcher) thro
shipInfo.getFacilityId()).queryOne();
} catch (GenericEntityException e) {
Debug.logError("Error :" + e.getMessage(), MODULE);
e.printStackTrace();
}

String requirementMethodEnumId = storeRequirementMethodEnumId;
Expand Down
2 changes: 1 addition & 1 deletion framework/base/src/main/java/org/apache/ofbiz/base/util/UtilXml.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,7 +1261,7 @@ public static String convertDocumentToXmlString(Document document) {
String output = writer.getBuffer().toString();
return output;
} catch (TransformerException e) {
e.printStackTrace();
Debug.logError(e, MODULE);
}

return null;
Expand Down
2 changes: 1 addition & 1 deletion framework/service/src/main/java/org/apache/ofbiz/service/ModelServiceReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ private static Document getDocument(URL url) {
if (sxe.getException() != null) {
x = sxe.getException();
}
x.printStackTrace();
Debug.logError(x, MODULE);
} catch (ParserConfigurationException | IOException e) {
// Parser with specified options can't be built
Debug.logError(e, MODULE);
Expand Down
2 changes: 1 addition & 1 deletion framework/service/src/main/java/org/apache/ofbiz/service/rmi/ExampleRemoteClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public ExampleRemoteClient() {
try {
rd = (RemoteDispatcher) Naming.lookup(RMI_URL);
} catch (NotBoundException | RemoteException | MalformedURLException e) {
e.printStackTrace();
Debug.logError(e, MODULE);
}
}

Expand Down
5 changes: 4 additions & 1 deletion ...rk/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import javax.servlet.http.HttpSession;

import org.apache.ofbiz.base.util.UtilCodec.SimpleEncoder;
import org.apache.ofbiz.base.util.Debug;
import org.apache.ofbiz.base.util.UtilHttp;
import org.apache.ofbiz.base.util.UtilProperties;
import org.apache.ofbiz.base.util.template.FreeMarkerWorker;
Expand Down Expand Up @@ -73,6 +74,8 @@

public class MacroFormRendererTest {

public static final String MODULE = MacroFormRendererTest.class.getName();

@Injectable
private HttpServletRequest request;

Expand Down Expand Up @@ -302,7 +305,7 @@ public void checkFieldMacroRendered(@Mocked ModelFormField.CheckField checkField
try {
macroFormRenderer.renderCheckField(writer, context, checkField);
} catch (IOException e) {
e.printStackTrace();
Debug.logError(e, MODULE);
}

assertAndGetMacroString("renderCheckField", ImmutableMap.of(
Expand Down
Loading