[MNG-8242] Cache flattened parents during model building #1703
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
force-pushed
the
MNG-8242
branch
2 times, most recently
from
bea30ec to
2ac280f
Compare
cstamas
approved these changes
Sep 18, 2024
During model building, we do not cache any hierarchy inheritance due to profiles that may be activated based on properties from the child projects. So there's no way to cache the effective parent and just inject it into the child, the whole hierarchy need to be taken into account. However, flattening the parent (i.e. inject the flattened parent's parent into the raw parent) should provide a parent model which has no parents anymore, not activated and not interpolated, but which can be cached and reused. # Conflicts: # maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java # Conflicts: # maven-api-impl/src/main/java/org/apache/maven/internal/impl/resolver/DefaultModelResolver.java # maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/MNG-8242
During model building, we do not cache any hierarchy inheritance due to profiles that may be activated based on properties from the child projects.
So there's no way to cache the effective parent and just inject it into the child, the whole hierarchy need to be taken into account.
However, flattening the parent (i.e. inject the flattened parent's parent into the raw parent) should provide a parent model which has no parents anymore, not activated and not interpolated, but which can be cached and reused.