Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6973][AUTHZ] Support Paimon DELETE FROM / UPDATE / MERGE INTO commands #6974

Closed
wants to merge 5 commits into from

Conversation

davidyuan1223
Copy link
Contributor

@davidyuan1223 davidyuan1223 commented Mar 8, 2025

Why are the changes needed?

Support ranger check with paimon Update & Delete & MergeInti Table Command

How was this patch tested?

Test Paimon Update & Delete Table Command with ranger check
#6973

Was this patch authored or co-authored using generative AI tooling?

No

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f844a05) to head (3bd6073).
Report is 4 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6974   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         689     689           
  Lines       42637   42637           
  Branches     5804    5804           
======================================
  Misses      42637   42637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Conflicts:
#	extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala
@davidyuan1223 davidyuan1223 changed the title [KYUUBI #6973] Test Table Update & Delete [KYUUBI #6973] Test Table Update & Delete & MergeInto Mar 10, 2025
@@ -31,6 +31,8 @@ import org.apache.kyuubi.util.AssertionUtils._
@PaimonTest
class PaimonCatalogRangerSparkExtensionSuite extends RangerSparkExtensionSuite {
override protected val catalogImpl: String = "hive"
override protected val sqlExtensions: String =
"org.apache.paimon.spark.extensions.PaimonSparkSessionExtensions"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this would break the Scala 2.13 UT, if so, you may want to enable this extension conditionally, or ask the Paimon community to handle Scala 2.13 properly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? I will check it after test workflow complete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this would break the Scala 2.13 UT, if so, you may want to enable this extension conditionally, or ask the Paimon community to handle Scala 2.13 properly.

you are right, i found paimon-spark profile has some questions, it only support spark3 with scala2.12, then the spark4 with scala2.13, i will jump the test case when scala version is 2.13, then i will submit an issue in paimon community

@pan3793 pan3793 changed the title [KYUUBI #6973] Test Table Update & Delete & MergeInto [KYUUBI #6973][AUTHZ] Support Paimon DELETE FROM / UPDATE / MERGE INTO commands Mar 12, 2025
@pan3793 pan3793 closed this in f927245 Mar 12, 2025
@pan3793
Copy link
Member

pan3793 commented Mar 12, 2025

Thanks, merged to master

@pan3793 pan3793 added this to the v1.11.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants