-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6936] Test RenameTable command #6937
[KYUUBI #6936] Test RenameTable command #6937
Conversation
The command has some question, ranger not check the rename command, so that the someone user could execute this command |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6937 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 689 689
Lines 42637 42637
Branches 5804 5804
======================================
Misses 42637 42637 ☔ View full report in Codecov by Sentry. |
# Conflicts: # extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala
i write renameTable command in table_command_spec.json, i'm not sure is that right? could you review? |
ps: the other lake test suite looks like not test the rename table command? so that we not found this question |
We shall rename the PR title, RenameTable is a generic one |
I wanna ask a question, if the logical plan's classname cannot found in the xxx_command_spec.json, can we use plan.isInstanceof[command_spec.classname] try to get the parent class descs to resolve? |
like the remove UnsetTableProperties command, can we use altertable command to resolve authz check? |
We have a plan to support custom_x_command_spec.json files for users to extend |
the other subtasks refer to #5470, currently only missing DML and procedures, please review them |
please sync master branch |
…rename_table # Conflicts: # extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala
# Conflicts: # extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala
resolved |
Merged to master, thank you |
Why are the changes needed?
Test Authz Support paimon rename table name command privilege check
#6936
How was this patch tested?
Test Authz Support paimon rename table name command privilege check
Was this patch authored or co-authored using generative AI tooling?
No