Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6936] Test RenameTable command #6937

Conversation

davidyuan1223
Copy link
Contributor

Why are the changes needed?

Test Authz Support paimon rename table name command privilege check
#6936

How was this patch tested?

Test Authz Support paimon rename table name command privilege check

Was this patch authored or co-authored using generative AI tooling?

No

@davidyuan1223
Copy link
Contributor Author

davidyuan1223 commented Feb 22, 2025

The command has some question, ranger not check the rename command, so that the someone user could execute this command
@pan3793

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (37eaf75) to head (797d1c4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6937   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         689     689           
  Lines       42637   42637           
  Branches     5804    5804           
======================================
  Misses      42637   42637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala
@davidyuan1223
Copy link
Contributor Author

i write renameTable command in table_command_spec.json, i'm not sure is that right? could you review?
@pan3793 @yaooqinn @bowenliang123

@davidyuan1223
Copy link
Contributor Author

davidyuan1223 commented Feb 24, 2025

ps: the other lake test suite looks like not test the rename table command? so that we not found this question

@yaooqinn
Copy link
Member

We shall rename the PR title, RenameTable is a generic one

@davidyuan1223 davidyuan1223 changed the title [WIP][KYUUBI #6936] test paimon rename table name command [KYUUBI #6936] Test RenameTable command Feb 25, 2025
@davidyuan1223
Copy link
Contributor Author

davidyuan1223 commented Feb 25, 2025

We shall rename the PR title, RenameTable is a generic one

I wanna ask a question, if the logical plan's classname cannot found in the xxx_command_spec.json, can we use plan.isInstanceof[command_spec.classname] try to get the parent class descs to resolve?

@davidyuan1223
Copy link
Contributor Author

We shall rename the PR title, RenameTable is a generic one

I wanna ask a question, if the logical plan's classname cannot found in the xxx_command_spec.json, can we use plan.isInstanceof[command_spec.classname] to get the parent class descs to resolve?

We shall rename the PR title, RenameTable is a generic one

I wanna ask a question, if the logical plan's classname cannot found in the xxx_command_spec.json, can we use plan.isInstanceof[command_spec.classname] try to get the parent class descs to resolve?

like the remove UnsetTableProperties command, can we use altertable command to resolve authz check?

@yaooqinn
Copy link
Member

yaooqinn commented Mar 3, 2025

if the logical plan's classname cannot found in the xxx_command_spec.json

We have a plan to support custom_x_command_spec.json files for users to extend

@davidyuan1223
Copy link
Contributor Author

davidyuan1223 commented Mar 3, 2025

if the logical plan's classname cannot found in the xxx_command_spec.json

We have a plan to support custom_x_command_spec.json files for users to extend

the other subtasks refer to #5470, currently only missing DML and procedures, please review them

@yaooqinn
Copy link
Member

yaooqinn commented Mar 5, 2025

please sync master branch

…rename_table

# Conflicts:
#	extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala
# Conflicts:
#	extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala
@davidyuan1223
Copy link
Contributor Author

please sync master branch

resolved

@yaooqinn yaooqinn added this to the v1.11.0 milestone Mar 5, 2025
@yaooqinn
Copy link
Member

yaooqinn commented Mar 5, 2025

Merged to master, thank you

@yaooqinn yaooqinn closed this in 61b6977 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants