Support for Map values in ClickHouse settings #1896
Merged
+112
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jun 22, 2025
There was a problem hiding this comment.
Thanks @solontsev! The changes look reasonable to me overall, left a couple minor comments
iffyio
reviewed
Jun 24, 2025
|
@solontsev when you have some time could you merge in the latest from main in order to fix the ci lint failures? |
Done. Should be OK now |
iffyio
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://clickhouse.com/docs/operations/settings/settings#additional_table_filters
Current implementation only parses simple settings with key = value format