Snowflake: support multiple column options in CREATE VIEW
#1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliaperantoni
changed the title
CREATE VIEWCREATE VIEW (and non-comment options for Snowflake)
eliaperantoni
changed the title
CREATE VIEW (and non-comment options for Snowflake)CREATE VIEW multiple column options and Snowflake fixes
iffyio
reviewed
Jun 21, 2025
iffyio
changed the title
CREATE VIEW multiple column options and Snowflake fixes CREATE VIEW
|
Thank you for your feedback @iffyio, I have addressed it and pushed the changes 😊 |
iffyio
reviewed
Jun 25, 2025
|
Updated @iffyio :) Thanks for your feedback! |
iffyio
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Snowflake query like:
Would've previously failed because of two reasons:
COLcolumn, but only one is currently parsed forCREATE VIEWstatements.COMMENT, which is the only one currently supported for the Snowflake dialect.This PR fixes both.
Additionally, it records in the AST whether the options are comma separated or not. Otherwise,
ToStringwouldn't produce a syntactically valid query for Snowflake.