Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-14164 Use native Promises instead of Q #94

Merged
merged 1 commit into from
Jul 4, 2018
Merged

CB-14164 Use native Promises instead of Q #94

merged 1 commit into from
Jul 4, 2018

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Jun 22, 2018 •
edited
Loading

What does this PR do?

Use native Promises instead of Q

What testing has been done on this change?

Checked if plugman still runs commands

@raphinesse raphinesse force-pushed the q-nomore branch 2 times, most recently from 53f0477 to 3c19b0f Compare June 22, 2018 23:26
@raphinesse raphinesse requested a review from dpogue July 4, 2018 23:40
dpogue
dpogue approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raphinesse raphinesse merged commit 944e8e6 into apache:master Jul 4, 2018
@raphinesse raphinesse deleted the q-nomore branch July 4, 2018 23:43
@raphinesse raphinesse mentioned this pull request Sep 11, 2018
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphinesse @dpogue