Fix orgy #113
Merged
Fix orgy #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
reviewed
Apr 2, 2019
|
@dpogue Oh, nevermind the CI. There are no tests anyway 😋 Okay, I'm being unfair here. There is one test case. And it tested the parsing of options that should not even exist before I fixed it here 😁 |
Instead of --plugin_{id,version} we had --platform_{id,version}
As unknown options are always interpreted as Boolean, before this fix
the created plugin.xml always contains <plugin id="true" version="true">
See also apache#110 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Plugman is horribly broken in so many aspects. This PR fixes some of the bugs. All changes are only patch level IMO.
Fixes #111
Description
See commits for details.
Testing
I did manual testing of all but the
installanduninstallcommands. The one existing test case passes.