Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-45700: [C++] Added nullptr check in Equals method to handle null impl_ pointers #45701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-45700: [C++] Added nullptr check in Equals method to handle null impl_ pointers #45701

wants to merge 1 commit into from
+7 −0

Conversation

mroz45
Copy link
Contributor

@mroz45 mroz45 commented Mar 7, 2025 •
edited by github-actions bot
Loading

Rationale for this change

What changes are included in this PR?

This PR adds a check to ensure that the Expression is not nullptr

Are these changes tested?

Yes.

Are there any user-facing changes?

No

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

⚠️ GitHub issue #45700 has been automatically assigned in GitHub to PR creator.

raulcd
raulcd approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've validated that the added test currently results on a segmentation fault.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 7, 2025
@raulcd
Copy link
Member

raulcd commented Mar 7, 2025 •
edited
Loading

Please if you could rebase once:

is closed so we can validate CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroz45 @raulcd