Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use correct GitHub Actions permission "contents" instead of "content" #200

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Nov 25, 2024

Rationale for this change

The syntax for permissions should use contents instead of content, see: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idpermissions

What changes are included in this PR?

Update to correct GitHub actions syntax.

Are these changes tested?

No, but can be seen the usage on the Arrow repo: https://github.com/apache/arrow/blob/bbda6b1e1322c5a9b8c107a03343d18b759694c1/.github/workflows/comment_bot.yml#L28

Are there any user-facing changes?

No

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@assignUser assignUser changed the title fix(ci): use correct github action permission contents instead of content ci: use correct github action permission contents instead of content Nov 25, 2024
@assignUser
Copy link
Member

I edited the title as afaik fix should only be used when it's in a part of the code base that influences the semver (as it bumps the patch component). Also @zeroshade do you merge via Github UI here?

@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

I edited the title as afaik fix should only be used when it's in a part of the code base that influences the semver (as it bumps the patch component).

Maybe would be nice to add some examples and/or guidelines on the contributing guide like on the angular contributing guidelines:
https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou changed the title ci: use correct github action permission contents instead of content ci: use correct GitHub Actions permission "contents" instead of "content" Nov 26, 2024
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raulcd raulcd merged commit dc8b257 into apache:main Nov 26, 2024
24 checks passed
@raulcd raulcd deleted the fix-workflow-permissions branch November 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants