feat(arrow/compute): make is_nan dispatchable #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
oops you're right, mis-named the PR, it's |
zeroshade
changed the title
lidavidm
approved these changes
Oct 29, 2024
joellubi
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
is_nancompute kernel is aMetaFunctionwhich cannot be dispatched via kernel dispatch making it only usable via calling it directly withCallFunction. By shifting it to be a proper function instead of aMetaFunctionthis improves its compatibility and makes it able to be dispatched and thus called through the substrait interface in theexprspackage.