Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siwave solve bug fix on Linux #305

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

svandenb-dev
Copy link
Collaborator

#297 bug fix

@svandenb-dev svandenb-dev added the bug Something isn't working label Apr 2, 2024
@svandenb-dev svandenb-dev self-assigned this Apr 2, 2024
@svandenb-dev svandenb-dev linked an issue Apr 2, 2024 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.10%. Comparing base (2de2718) to head (842a6b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   84.11%   84.10%   -0.01%     
==========================================
  Files         105      105              
  Lines       17914    17916       +2     
==========================================
+ Hits        15068    15069       +1     
- Misses       2846     2847       +1     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 8b30368 into main Apr 2, 2024
26 checks passed
@svandenb-dev svandenb-dev deleted the siwave_solve_linux_bug_fix branch April 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyedb/generic/process.py solve_siwave fails in linux due to popen
3 participants