Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add ServerContext, ServerConfiguration and GettingStartedWithDPFServer sections #637

Merged
merged 50 commits into from
Nov 30, 2022

Conversation

anslpa
Copy link
Contributor

@anslpa anslpa commented Nov 23, 2022

In the User Guide, 3 sections have been added:

  • Server Context
  • Server Configuration
  • Getting Started with DPF Server

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #637 (7f5b322) into master (b58b329) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   88.11%   88.06%   -0.06%     
==========================================
  Files          69       69              
  Lines        7750     7756       +6     
==========================================
+ Hits         6829     6830       +1     
- Misses        921      926       +5     

Running the DPF Server
~~~~~~~~~~~~~~~~~~~~~~

On Windows, start the DPF Server by running the Ans.Dpf.Grpc.bat file in the unzipped package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anslpa I would rather specify the batch and bash files at the end because user should not have to do it.
We could instead explain that the first entity created will start on (give a Field example maybe) and show the start_local_server snippet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !


DPF capabilities are available through the following main services:
- Entry: Loads the minimum number of plugins for basic use. It is the default. It will only check if an Ansys License is available.
- Premium: Uses the premium DataProcessingCore.xml file to load most plugins.... with their environments. It will checkout a license.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not true I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi I took that comment into account.

default capabilities a server will be started with.

The server context is composed of the following information:
- context_type, :class:`LicensingContextType <ansys.dpf.core.server_context>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have the same link for AvailableServerContexts and LicensingContextType?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000 the link is to the module in which the class is, isn't it?

Getting started with Entry capabilities
---------------------------------------

Find the list of operators available when the context is Entry at :ref:`ref_dpf_operators_reference`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to coordinate with @PProfizi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine, I did not change the reference name

Terminology
-----------

DPF is based on a **client-server** architecture. It allows **local** or **remote**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the getting started section, I went for communication "in process" or "through the network" to be closer to the truth. We can use either one or the other but should be consistent maybe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi I took that comment into account, and the discussion we had yesterday; we can discuss it if needed.

@PProfizi PProfizi self-assigned this Nov 29, 2022
Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the documentation generated, LGTM

@PProfizi PProfizi merged commit d08a5f3 into master Nov 30, 2022
@PProfizi PProfizi deleted the doc/contexts branch November 30, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants