Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: update HDF5 "import and export" to use operators.result.custom #2045

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

oparreno
Copy link
Contributor

  • Add result_name pin in custom operator.
  • Modify 02-hdf5_serialize_and_read example to use the source operator instead.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (74c4691) to head (d625581).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
- Coverage   88.62%   88.61%   -0.01%     
==========================================
  Files          90       90              
  Lines       10225    10225              
==========================================
- Hits         9062     9061       -1     
- Misses       1163     1164       +1     

@oparreno oparreno self-assigned this Jan 29, 2025
@rafacanton
Copy link
Contributor

@oparreno The operators code is autogenerated, we shouldn't modify it manually. Changes will be ported from the server when the hdf5 issue is fixed

@oparreno oparreno merged commit 6f0cbf6 into master Jan 30, 2025
46 checks passed
@oparreno oparreno deleted the oparreno/custom_exaple branch January 30, 2025 13:27
@PProfizi PProfizi added the examples Related to PyDPF-Core examples label Feb 3, 2025
@PProfizi PProfizi added this to the 0.13.5 milestone Feb 3, 2025
@PProfizi PProfizi changed the title Add result_name pin in custom and modify example Example: update HDF5 serialize and read to use operators.result.custom Feb 3, 2025
@PProfizi PProfizi changed the title Example: update HDF5 serialize and read to use operators.result.custom Example: update HDF5 "serialize and read" to use operators.result.custom Feb 3, 2025
@PProfizi PProfizi changed the title Example: update HDF5 "serialize and read" to use operators.result.custom Example: update HDF5 "import and export" to use operators.result.custom Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to PyDPF-Core examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants