Fix a bug where a new server is run on object creation #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1592 +/- ##
==========================================
+ Coverage 80.12% 87.02% +6.90%
==========================================
Files 82 82
Lines 9671 9683 +12
==========================================
+ Hits 7749 8427 +678
+ Misses 1922 1256 -666 |
cbellot000
approved these changes
May 28, 2024
cbellot000
reviewed
May 28, 2024
| @@ -299,3 +299,17 @@ def test_mutable_ids_data(server_clayer): | |||
| data = None | |||
| changed_data = scop.ids | |||
| assert np.allclose(changed_data[0], data_copy[0] + 2) | |||
|
|
|||
|
|
|||
| def test_scoping_dont_start_server(server_type): | |||
There was a problem hiding this comment.
could we maybe loop over supported types you updated ?
|
@cbellot000 FYI could not replicate with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a Python DPF object based on another Python DPF object triggered a new server instead of using the server of the object given as input.