feat: log stacktrace with just file, function name and line number #751
+135
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
force-pushed
the
log_stacktrace
branch
2 times, most recently
from
7f7382d to
a99e4c0
Compare
A regular stack trace will print out args, data which can lead to security leak. So we want to limit the stack trace to just * source file name * function name * line number This will help users debug their source plugins etc, otherwise it would be very challenging to locate where the code has issues https://issues.redhat.com/browse/AAP-41261
hsong-rh
approved these changes
Mar 7, 2025
ttuffin
approved these changes
Mar 10, 2025
|
Alex-Izquierdo
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regular stack trace will print out args, data which can lead to security leak. So we want to limit the stack trace to just
This will help users debug their source plugins etc, otherwise it would be very challenging where the code has issues
https://issues.redhat.com/browse/AAP-41261
