Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport): set python3.11 as the minimal supported version (#649) #657

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/run-flake/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ runs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "3.11"

- name: Install dependencies
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/run-isort/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ runs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "3.11"

- name: Install dependencies
shell: bash
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ jobs:
strategy:
matrix:
python-version:
- "3.9"
- "3.10"
- "3.11"

steps:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/scheduled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ jobs:
strategy:
matrix:
python-version:
- "3.9"
- "3.10"
- "3.11"

steps:
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ version: 2
build:
os: ubuntu-22.04
tools:
python: "3.9"
python: "3.11"

# Build documentation in the docs/ directory with Sphinx
sphinx:
Expand Down
12 changes: 9 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/centos/centos:stream9-development
FROM quay.io/centos/centos:stream9

ARG USER_ID=${USER_ID:-1001}
ARG APP_DIR=${APP_DIR:-/app}
Expand All @@ -10,15 +10,21 @@ RUN useradd -u $USER_ID -d $APP_DIR appuser
WORKDIR $APP_DIR
COPY . $WORKDIR
RUN chown -R $USER_ID $APP_DIR
RUN dnf install -y java-17-openjdk-devel python3-pip postgresql-devel gcc python3-devel
RUN dnf install -y \
java-17-openjdk-devel \
python3.11 \
python3.11-pip \
postgresql-devel \
gcc \
python3.11-devel

RUN bash -c "if [ $DEVEL_COLLECTION_LIBRARY -ne 0 ]; then \
dnf install -y git; fi"

USER $USER_ID
ENV JAVA_HOME=/usr/lib/jvm/java-17-openjdk
ENV PATH="${PATH}:$APP_DIR/.local/bin"
RUN pip install -U pip \
RUN pip3.11 install -U pip \
&& pip install ansible-core \
ansible-runner \
jmespath \
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Before you submit a pull request, check that it meets these guidelines:
2. If the pull request adds functionality, the docs should be updated. Put
your new functionality into a function with a docstring, and add the
feature to the list in README.rst.
3. The pull request should work for Python 3.9
3. The pull request should work for Python 3.11
4. Commit messages must conform to `conventional commit <https://www.conventionalcommits.org/en/v1.0.0/>`__


Expand Down
2 changes: 1 addition & 1 deletion docs/development_environment.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Ready to contribute? Here's how to set up `ansible_rulebook` for local developme
.. code-block:: console

cd ansible_rulebook/
python3.9 -m venv venv
python3.11 -m venv venv
source venv/bin/activate
pip install -e .[development]
pip install -r requirements_dev.txt
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Please ensure you have installed all components listed in the **Requirements** s
Requirements
------------

* Python >= 3.9
* Python >= 3.11
* Python 3 pip

* Java development kit >= 17
Expand Down
4 changes: 1 addition & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@ classifiers =
License :: OSI Approved :: Apache Software License
Natural Language :: English
Programming Language :: Python :: 3
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11

[options]
zip_safe = False
include_package_data = True
packages = find:
python_requires = >=3.9
python_requires = >=3.11
install_requires =
aiohttp
pyparsing >= 3.0
Expand Down
4 changes: 1 addition & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
[tox]
envlist = flake8,py39,py310,py311
envlist = flake8,py311
isolated_build = True

[travis]
python =
3.9: py39
3.10: py310
3.11: py311

[testenv:flake8]
Expand Down
Loading