Fix easy days causing load balancer to disproportionately schedule graduates to the furthest day #3643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where easy days is effectively disabled (all days are set to the same ease), do not call its corresponding routines.
Take this case of graduating intervals:
Here are the intervals with only the load balancer operating
(format is
interval: cards_due_on_day, normalized_weight (raw_weight)
):However after the easy days logic gets run (but all days are all set to
Normal
), the intervals becomeWe're effectively back to the old problem of graduates getting disproportionately placed on the furthest day due to the inherent dip that is created at that point.
Interestingly, having at least one day changed does provide a reasonable-enough load balance:
monday minimal:
tuesday minimal: