Fix deck button not clickable in stats screen for smaller screens #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed z-index of the underlying spinner
|
@Sawansunar56 can you add a quick screen capture or image showing the UI affects of this, and explain in your PR description above (with an edit...) exactly what was done and why? That would help review a lot Thanks! |
anki_capture.mp4NOTE: I increased the opacity of the spinner for this instance to show the change. |
mikehardy
approved these changes
Nov 29, 2024
I appreciate the input as well. |
abdnh
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3595
Changed the z-index of the spinner element in the stats screen, which caused the spinner to take the click events if the spinner and the radio buttons(deck, collection) were on top of each other, due to insufficient space. I just made it so that it goes behind if the element is not loading and in front if it is.