This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(layouts): register Layout directives for xs, gt-xs, xl #6037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
added
needs: review
* Refactor Layout API directive registration to iteration all known breakpoints. * Update `layout.spec.js` tests to test all breakpoints Fixes #5983.
ThomasBurleson
force-pushed
the
wip/fix_layout_breakpoints
branch
from
10ab79b to
c6449e2
Compare
| var SPECIAL_CHARS_REGEXP = /([\:\-\_]+(.))/g; | ||
|
|
||
| // NOTE: these are also defined in constants::MEDIA_PRIORITY and constants::MEDIA | ||
| var BREAKPOINTS = [ "", "xs", "gt-xs", "sm", "gt-sm", "md", "gt-md", "lg", "gt-lg", "xl" ]; |
There was a problem hiding this comment.
Now that I think about it, how much of a performance impact does adding all of these directives have? This currently registers 90 directives just in this loop (or 109 total).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layout.spec.jstests to test all breakpointsFixes #5983.