Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(docs): Use $scope instead of scope #2836

Closed
wants to merge 1 commit into from

Conversation

miensol
Copy link
Contributor

@miensol miensol commented May 13, 2015

To avoid confusion it would be good to keep the examples consistent.
While scope in DialogController will be the same as $scope it brings confusion to a reader.
I can only guess that scope here working is by accident - caused by

angular.extend(compileData.locals, self.options);
.

The fix also includes missing } mentioned here: #2788

Here's a working pen: http://codepen.io/anon/pen/ZGWOpZ.

To avoid confusion I guess it would be good to keep the examples consistent.
While `scope` in `DialogController` will be the same as `$scope` it brings confusion to the reader.
I can only guess that `scope` here working is only by accident - caused by https://github.com/angular/material/blob/786b0ed3652b7460c2c802efa1aa79972bd96f5d/src/core/services/interimElement/interimElement.js#L353.

The fix also includes missing `}` mentioned here:   angular#2788

Here's a working pen: http://codepen.io/anon/pen/ZGWOpZ.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@miensol
Copy link
Contributor Author

miensol commented May 13, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented May 13, 2015

The example does not work anyway. There are several issues that need to be fixed.

BTW, @ThomasBurleson, the examples in the Services section seem to be derived from comments. As a result they are not editable in CodePen and (most importantly) they are not run in tests (which may result in incorrect/outdated code => confusion).
Something should probably be done about it :)

@ThomasBurleson
Copy link
Contributor

@gkalpak - #2869

@gkalpak
Copy link
Member

gkalpak commented May 15, 2015

👍 @ThomasBurleson

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants