Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(versions): provide version menu for navigating to versioned docs #1904

Closed

Conversation

radamant
Copy link

This was created in collaboration with @marcysutton.

Refs #918 provides version menu (with customizable minimum-version cutoff)
that navigates to docs based on a simple string format.

This approach was based on that provided in the base angular.js repo,
and some of the code was ported from that repo.

It looks like this:

screenshot 2015-03-13 15 05 24

screenshot 2015-03-13 14 26 39

As aforementioned, this works pretty much identically to the one in the angular.js repo, using much of the same code. It gets previous version from the list of tags, and adds a CDN and snapshotted version if available. The doc url generation is controlled by two variables, one to determine the minimum version for which doc urls will be generated, the other to format of the URL for versioned docs (none of the URLs currently exist.)

I do not have access to either material's public-facing servers nor its CI configuration(s), so there are still several items that must be done before this can be rolled out:

Refs angular#918 provides version menu (with customizable min-version cutoff)
that navigates to docs based on a simple string format.

This approach was based on that provided in the base angular.js repo,
and some of the code was ported from that repo.
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@radamant
Copy link
Author

@googlebot CLA is signed.

@googlebot
Copy link

CLAs look good, thanks!

@ThomasBurleson
Copy link
Contributor

@marcysutton - this PR is incomplete due to dependent features:

@robertmesserle - can you and I work with BrianF to prepare these above items for 0.9 release?

@ThomasBurleson ThomasBurleson self-assigned this Apr 1, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.10.0, 0.9.0 Apr 5, 2015
@ThomasBurleson
Copy link
Contributor

Closed. See SHA 57e9ea4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants