This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(nav-bar): throws exception when indexing null tabs variable #11965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
- `MdNavBarController._getTabs()` returns an empty array instead of `null` to match existing return type - rename `MdNavItemController._focused` to `MdNavItemController.isFocused` - make it non-private since it is accessed by `MdNavBarController.onFocus()` - fix/improve types - remove unused variables - add JSDoc Relates to #11964
Splaktar
force-pushed
the
navbar-fix-exception
branch
from
4673bdf to
15181ff
Compare
andrewseguin
approved these changes
Jul 17, 2020
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
Relates to #11964
What is the new behavior?
MdNavBarController._getTabs()returns an empty array instead ofnullto match existing return type
MdNavItemController._focusedtoMdNavItemController.isFocusedMdNavBarController.onFocus()Does this PR introduce a breaking change?
Other information
The test will be added via PR #11964.