This repository was archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
input-container: not showing ng-messages error by default even when md-auto-hide="false" is applied #9723
Labels
has: Pull Request
A PR has been created to address this issue
P4: minor
Minor issues. May not be fixed without community contributions.
resolution: fixed
ui: CSS
Milestone
Comments
Currently my quick and dirty fix in our project is: Add these lines of code to
This ensure that the error message will be appeared from the start when there is no Also I replaced this logic:
Still the label is NOT colored red by default. I have tried this but it didn't work:
I guess to make that possible some logic inside |
+1 |
clshortfuse
added a commit
that referenced
this issue
Jan 10, 2017
With commit cf7f21a, animations were moved to input.js in response to an ng-enter flicker issue with Angular 1.4.x. While the flicker was fixed, new animation bugs arised. Angular 1.4.x added and backported a ng-enter-prepare to avoid this bug. * Remove JS animations for input messages * Use `.ng-enter-prepare` to avoid flicker on Angular 1.4+ * Use `.ng-enter:not(ng-enter-active)` to prepare animations on 1.3+ and below * Update spec tests to use getComputedStyle instead of ngAnimate Fixes #6767, #9543, #9723, #10240 Related: angular/angular.js#13408
clshortfuse
added a commit
that referenced
this issue
Jan 10, 2017
With commit cf7f21a, animations were moved to input.js in response to an ng-enter flicker issue with Angular 1.4.x. While the flicker was fixed, new animation bugs arised. Angular 1.4.x added and backported a ng-enter-prepare to avoid this bug. * Remove JS animations for input messages * Use `.ng-enter-prepare` to avoid flicker on Angular 1.4+ * Use `.ng-enter:not(.ng-enter-active)` to prepare animations on 1.3+ and below * Update spec tests to use getComputedStyle instead of ngAnimate Fixes #6767, #9543, #9723, #10240 Related: angular/angular.js#13408
clshortfuse
added a commit
that referenced
this issue
Jan 10, 2017
With commit cf7f21a, animations were moved to input.js in response to an ng-enter flicker issue with Angular 1.4.x. While the flicker was fixed, new animation bugs arised. Angular 1.4.x added and backported a ng-enter-prepare to avoid this bug. * Remove JS animations for input messages * Use `.ng-enter-prepare` to avoid flicker on Angular 1.4+ * Use `.ng-enter:not(.ng-enter-active)` to prepare animations on 1.3 and below * Update spec tests to use getComputedStyle instead of ngAnimate Fixes #6767, #9543, #9723, #10240 Related: angular/angular.js#13408
clshortfuse
added a commit
that referenced
this issue
Jan 10, 2017
With commit cf7f21a, animations were moved to input.js in response to an ng-enter flicker issue with Angular 1.4.x. While the flicker was fixed, new animation bugs arised. Angular 1.4.x added and backported a ng-enter-prepare to avoid this bug. * Use `.ng-enter-prepare` to avoid flicker on Angular 1.4+ * Use `.ng-enter:not(.ng-enter-active)` to prepare animations on 1.3 and below Fixes #6767, #9543, #9723, #10240 Related: angular/angular.js#13408
clshortfuse
added a commit
that referenced
this issue
Jan 10, 2017
With commit cf7f21a, animations were moved to input.js in response to an ng-enter flicker issue with Angular 1.4.x. While the flicker was fixed, new animation bugs arised. Angular 1.4.x added and backported a ng-enter-prepare to avoid this bug. * Use `.ng-enter-prepare` to avoid flicker on Angular 1.4+ * Use `.ng-enter:not(.ng-enter-active)` to prepare animations on 1.3 and below * Update spec tests to use computedStyle Fixes #6767, #9543, #9723, #10240 Related: angular/angular.js#13408
Hi there, Is this still an issue? |
kara
pushed a commit
that referenced
this issue
Jul 18, 2017
Fixed in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
has: Pull Request
A PR has been created to address this issue
P4: minor
Minor issues. May not be fixed without community contributions.
resolution: fixed
ui: CSS
Actual Behavior:
What is the issue? *
: Undermd-input-container
, when appliedmd-auto-hide="false"
tong-messages
, error message(s) is not shown by default.What is the expected behavior?
: If the input is invalid, error message(s) should be shown by default whenmd-auto-hide="false"
is applied onng-messages
.CodePen (or steps to reproduce the issue): *
CodePen Demo which shows your issue:
http://codepen.io/vinhnghi223/pen/JRyoXJ ( I used the same example from Angular Material Input Errors demo: https://material.angularjs.org/latest/demo/input) (TheHourly Rate (USD)
example)Details:
I realized that the reason why the example on Angular Material Input Errors demo works is each tag, whereng-message
resides, has an inline styles ofstyle="opacity: 1; margin-top: 0px;"
.Angular Versions: *
Angular Version:
1.5.5Angular Material Version:
1.1.1Additional Information:
Browser Type: *
AnyBrowser Version: *
AnyOS: *
AnyStack Traces:
AnyThe text was updated successfully, but these errors were encountered: