-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Autocomplete suggestions remain at same position onScroll #2973
Comments
+1 |
Same here. Tried with 0.9.8. |
+1 (v. 0.10.0) |
+1 |
@robertmesserle How does this work if the input isn't visible when it gains focus? For example if you tab to an auto complete while you are scrolled past it. This sounds like it'd lock the view and be very hard to understand for the user. |
@epelc This is modeled after the way that select components work in Chrome on Mac. The screen is only locked when the select menu is showing. The browser should move the input into view when the user focuses it, but I'm going to spend some time today trying to break this and see if I can find any edge cases that need to be addressed. If you find any examples where this breaks, please send a CodePen my way. |
@robertmesserle Thanks. I was just going off the changelog info I didn't get to test it in my app yet. I'm waiting for a good time to update #2710 so I can get it merged soon. I've been running a fork for several weeks with that pr so I haven't been able to easily update and test the later 0.9.X and 0.10.X releases. I'll let you know if I find anything though. |
@epelc Interestingly, my description of how the browser would handle it worked in 0.9.8, but when tested against master just now, doesn't seem to move as expected. Might need to add a delay before locking scrolling to account for the browser's build-in functionality. |
Confirmed, that fixed it. Committing to master now. Good call! =p |
While typing if we scroll position of suggestion remain fixed

See the gap between input box and suggestion box
The text was updated successfully, but these errors were encountered: