fix(material/radio): required attribute being set on buttons #30434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naaajii
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
andrewseguin
reviewed
Feb 3, 2025
naaajii
force-pushed
the
fix/30399
branch
2 times, most recently
from
92c7a6b to
99d1dfd
Compare
fixes when `MatRadioGroup` is set to be required it was setting all of its `MatRadioButton` to be required as-well which is confusing for assistive technologies, this commit ensures we only set aria-required on group rather than all buttons unless button is being used standalone of `MatRadioGroup` fixes angular#30399
naaajii
commented
Feb 3, 2025
| // we never want to set required attribute on input when we have MatRadioGroup as we will set | ||
| // aria-required directly on MatRadioGroup if its required as setting on all MatRadioButton for | ||
| // it's MatRadioGroup would be confusing for assistive technology. | ||
| if (this.radioGroup) return null; |
There was a problem hiding this comment.
made it that if used with group we don't set required attribute on inputs, this might be breaking for people who explicitly set required on radios.
|
Hi! Is there any update for this PR? |
|
ello @clamli! I think the PR has the necessary changes to fix the issue & its pending a review. however if you feel like anything is missing from it feel free to ping me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes when
MatRadioGroupis set to be required it was setting all of itsMatRadioButtonto be required as-well which is confusing for assistive technologies, this commit ensures we only set aria-required on group rather than all buttons unless button is being used standalone ofMatRadioGroupfixes #30399