Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(theme-generator): errorColor and neutralVariantColor missing in schema #30571

Closed
1 task
RobSlgm opened this issue Mar 2, 2025 · 0 comments · Fixed by #30602
Closed
1 task

bug(theme-generator): errorColor and neutralVariantColor missing in schema #30571

RobSlgm opened this issue Mar 2, 2025 · 0 comments · Fixed by #30602
Assignees
@crisbeto
Labels
area: ng-generate Schematics that generate code in user projects P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@RobSlgm
Copy link

RobSlgm commented Mar 2, 2025

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

#30321 added options to customize colors for neutral variant and error color.

These options are not available on the command line, e.g.

 ng generate @angular/material:theme-color ... --error-color=#ff0022 --neutral-variant-color=#a09890

fails as neither 'error-color' or 'neutral-variant-color' are known.

The options are missing in @angular\material\schematics\ng-generate\theme-color\schema.json.

Reproduction

The issue is related to the usage on the command line, see statement above.

Expected Behavior

Add the options to the schema.json.

Actual Behavior

The command line statements returns with
Error: Unknown arguments: error-color, neutral-variant-color

Environment

  • CDK/Material: 19.2.1
  • Node: v22.14.0
@RobSlgm RobSlgm added the needs triage This issue needs to be triaged by the team label Mar 2, 2025
@crisbeto crisbeto self-assigned this Mar 7, 2025
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: ng-generate Schematics that generate code in user projects and removed needs triage This issue needs to be triaged by the team labels Mar 7, 2025
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 7, 2025
@crisbeto
fix(material/schematics): some options missing from schema
b50beb0 
Fixes that the `neutralVariantColor` and `errorColor` were missing from the schema which meant that users can't pass them in.

Fixes angular#30571.
@crisbeto crisbeto mentioned this issue Mar 7, 2025
Merged
crisbeto added a commit that referenced this issue Mar 7, 2025
@crisbeto
fix(material/schematics): some options missing from schema (#30602)
6d978a3 
Fixes that the `neutralVariantColor` and `errorColor` were missing from the schema which meant that users can't pass them in.

Fixes #30571.

(cherry picked from commit da371e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisbeto crisbeto

Labels
area: ng-generate Schematics that generate code in user projects P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/schematics): some options missing from schema crisbeto/material2
2 participants
@crisbeto @RobSlgm