Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Timepicker): Implement a MAT_TIMEPICKER_SCROLL_STRATEGY for the component #30421

Closed
laliconfigcat opened this issue Jan 30, 2025 · 1 comment · Fixed by #30473
Closed

feat(Timepicker): Implement a MAT_TIMEPICKER_SCROLL_STRATEGY for the component #30421

laliconfigcat opened this issue Jan 30, 2025 · 1 comment · Fixed by #30473
Assignees
@crisbeto
Labels
area: material/timepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@laliconfigcat
Copy link

laliconfigcat commented Jan 30, 2025 •
edited
Loading

Feature Description

First of all, thanks for the Timepicker component, I really waited for it and love it.

I'd have one feature request, I couldn't find a way to specify a scroll strategy for the component.
Like the MAT_MENU_SCROLL_STRATEGY, MAT_AUTOCOMPLETE_SCROLL_STRATEGY, MAT_SELECT_SCROLL_STRATEGY and MAT_DATEPICKER_SCROLL_STRATEGY for other components.
Scrolling can cause some crazy effects with the opened Timepicker. On material.angular.io it seems like this if i start scrolling:

Image

Would it be possible to implement a scroll strategy for the Timepicker too? Or if I am just missing something, could you please point me to the right direction?

Use Case

I'd like to control the scroll behaviour for the component.
@laliconfigcat laliconfigcat added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Jan 30, 2025
@laliconfigcat laliconfigcat changed the title feat(TimePicker): Implement a MAT_TIMEPICKER_SCROLL_STRATEGY for the component feat(Timepicker): Implement a MAT_TIMEPICKER_SCROLL_STRATEGY for the component Jan 30, 2025
@crisbeto crisbeto self-assigned this Feb 12, 2025
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/timepicker and removed feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Feb 12, 2025
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 12, 2025
@crisbeto
fix(material/timepicker): allow scroll strategy to be customized
0c5bb0f 
Adds an injection token to the timepicker that allows the scroll strategy to be customized, similar to other components.

Fixes angular#30421.
@crisbeto crisbeto mentioned this issue Feb 12, 2025
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 12, 2025
@crisbeto
fix(material/timepicker): allow scroll strategy to be customized
0c1e126 
Adds an injection token to the timepicker that allows the scroll strategy to be customized, similar to other components.

Fixes angular#30421.
crisbeto added a commit that referenced this issue Feb 12, 2025
@crisbeto
fix(material/timepicker): allow scroll strategy to be customized (#30473
0925cf5 
)

Adds an injection token to the timepicker that allows the scroll strategy to be customized, similar to other components.

Fixes #30421.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 12, 2025
@crisbeto
fix(material/timepicker): allow scroll strategy to be customized (ang…
e8e89d0 
…ular#30473)

Adds an injection token to the timepicker that allows the scroll strategy to be customized, similar to other components.

Fixes angular#30421.
@crisbeto crisbeto mentioned this issue Feb 12, 2025
Merged
crisbeto added a commit that referenced this issue Feb 12, 2025
@crisbeto
fix(material/timepicker): allow scroll strategy to be customized (#30473
e8d6454 
) (#30479)

Adds an injection token to the timepicker that allows the scroll strategy to be customized, similar to other components.

Fixes #30421.
@laliconfigcat
Copy link
Author

Thank you very much!

@laliconfigcat laliconfigcat mentioned this issue Mar 6, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisbeto crisbeto

Labels
area: material/timepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/timepicker): allow scroll strategy to be customized crisbeto/material2
2 participants
@crisbeto @laliconfigcat