test(@angular/cli): disable sourcemaps by default in test suite #6884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
test-no-sourcemaps
branch
2 times, most recently
from
4cc33a5 to
5f6a085
Compare
hansl
reviewed
Jul 4, 2017
tests/e2e/utils/process.ts
Outdated
| // We add these flags before other args so that they can be overriden. | ||
| // e.g. `--no-sourcemaps --sourcemaps` will still generate sourcemaps. | ||
| if (cmd === 'ng' && ['build', 'serve', 'test', 'e2e', 'xi18n'].indexOf(args[0]) !== -1) { | ||
| args = [args[0], '--no-progress', '--no-sourcemaps', ...args.slice(1)] |
There was a problem hiding this comment.
Feels like we should have default values for those in the config, but I cannot find them. Ideas?
There was a problem hiding this comment.
We don't have those in the .angular-cli.json, no. I could add support for it and set them on the project creation phase.
There was a problem hiding this comment.
Fixed now that #6889 is in.
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Jul 5, 2017
Adds following defaults to `.angular-cli.json` under `defaults`: `sourcemaps`, `baseHref`, `progress`, `poll`, `deleteOutputPath`, `preserveSymlinks`, `showCircularDependencies`. They can be set via `ng set defaults.build.KEY = VALUE`. Also removes `apps.0.showCircularDependencies`. This is not a breaking chance since it was only added in 1.3.0-beta.0. Followup to angular#6884 (comment).
|
Blocked by #6889, which adds build defaults support to |
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Jul 5, 2017
Adds following defaults to `.angular-cli.json` under `defaults`: `sourcemaps`, `baseHref`, `progress`, `poll`, `deleteOutputPath`, `preserveSymlinks`, `showCircularDependencies`. They can be set via `ng set defaults.build.KEY = VALUE`. Also removes `apps.0.showCircularDependencies`. This is not a breaking chance since it was only added in 1.3.0-beta.0. Followup to angular#6884 (comment).
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Jul 5, 2017
Adds following defaults to `.angular-cli.json` under `defaults`: `sourcemaps`, `baseHref`, `progress`, `poll`, `deleteOutputPath`, `preserveSymlinks`, `showCircularDependencies`. They can be set via `ng set defaults.build.KEY = VALUE`. Also removes `apps.0.showCircularDependencies`. This is not a breaking chance since it was only added in 1.3.0-beta.0. Followup to angular#6884 (comment).
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Jul 5, 2017
Adds following defaults to `.angular-cli.json` under `defaults`: `sourcemaps`, `baseHref`, `progress`, `poll`, `deleteOutputPath`, `preserveSymlinks`, `showCircularDependencies`. They can be set via `ng set defaults.build.KEY = VALUE`. Also removes `apps.0.showCircularDependencies`. This is not a breaking chance since it was only added in 1.3.0-beta.0. Followup to angular#6884 (comment).
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Jul 6, 2017
Adds following defaults to `.angular-cli.json` under `defaults`: `sourcemaps`, `baseHref`, `progress`, `poll`, `deleteOutputPath`, `preserveSymlinks`, `showCircularDependencies`. They can be set via `ng set defaults.build.KEY = VALUE`. Also removes `apps.0.showCircularDependencies`. This is not a breaking chance since it was only added in 1.3.0-beta.0. Followup to angular#6884 (comment).
hansl
pushed a commit
that referenced
this pull request
Jul 6, 2017
Adds following defaults to `.angular-cli.json` under `defaults`: `sourcemaps`, `baseHref`, `progress`, `poll`, `deleteOutputPath`, `preserveSymlinks`, `showCircularDependencies`. They can be set via `ng set defaults.build.KEY = VALUE`. Also removes `apps.0.showCircularDependencies`. This is not a breaking chance since it was only added in 1.3.0-beta.0. Followup to #6884 (comment).
Note: this PR is for the repository test suite, not for project commands like `ng test`.
filipesilva
force-pushed
the
test-no-sourcemaps
branch
from
5f6a085 to
73eee99
Compare
hansl
pushed a commit
that referenced
this pull request
Jul 12, 2017
Adds following defaults to `.angular-cli.json` under `defaults`: `sourcemaps`, `baseHref`, `progress`, `poll`, `deleteOutputPath`, `preserveSymlinks`, `showCircularDependencies`. They can be set via `ng set defaults.build.KEY = VALUE`. Also removes `apps.0.showCircularDependencies`. This is not a breaking chance since it was only added in 1.3.0-beta.0. Followup to #6884 (comment).
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
Adds following defaults to `.angular-cli.json` under `defaults`: `sourcemaps`, `baseHref`, `progress`, `poll`, `deleteOutputPath`, `preserveSymlinks`, `showCircularDependencies`. They can be set via `ng set defaults.build.KEY = VALUE`. Also removes `apps.0.showCircularDependencies`. This is not a breaking chance since it was only added in 1.3.0-beta.0. Followup to angular#6884 (comment).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is for the repository test suite, not for project commands like
ng test.