fix(@angular/build): prevent fallback to serving main.js for unknown requests #29527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
main-serve-js
branch
from
8b56960 to
aa6a9c1
Compare
…requests Previously, when an unknown `main.js` file was requested, the system would automatically fall back to serving the default `main.js`. This behavior could cause unexpected issues, such as incorrect resource loading or misleading errors. This fix ensures that only valid `main.js` files are served, preventing unintended fallbacks and improving request handling. Closes angular#29524
alan-agius4
force-pushed
the
main-serve-js
branch
from
aa6a9c1 to
d997c35
Compare
clydin
approved these changes
Jan 29, 2025
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an unknown
main.jsfile was requested, the system would automatically fall back to serving the defaultmain.js. This behavior could cause unexpected issues, such as incorrect resource loading or misleading errors.This fix ensures that only valid
main.jsfiles are served, preventing unintended fallbacks and improving request handling.Closes #29524