Skip to content

fix(@angular/ssr): apply HTML transformation to CSR responses #29038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 4, 2024

Before this commit, HTML transformations were not applied to CSR responses, leading to the omission of the Vite client code.

Closes #29033

@alan-agius4 alan-agius4 requested a review from clydin December 4, 2024 08:47
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 4, 2024
Before this commit, HTML transformations were not applied to CSR responses, leading to the omission of the Vite client code.

Closes angular#29033
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 4, 2024
@alan-agius4 alan-agius4 merged commit f897b7a into angular:main Dec 4, 2024
30 of 31 checks passed
@alan-agius4 alan-agius4 deleted the ssr-ssg branch December 4, 2024 14:37
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page reload sent to client(s). Not working, Need to manually refresh page.
2 participants