Skip to content

fix(@angular/build): prevent errors with parameterized routes when getPrerenderParams is undefined #28954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

alan-agius4
Copy link
Collaborator

Ensure that parameterized routes do not cause errors when the getPrerenderParams function is undefined, specifically in cases where the routing API is not utilized.

Closes #28948

…etPrerenderParams` is undefined

Ensure that parameterized routes do not cause errors when the `getPrerenderParams` function is undefined, specifically in cases where the routing API is not utilized.

Closes angular#28948
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 25, 2024
@alan-agius4 alan-agius4 requested a review from clydin November 25, 2024 10:10
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 25, 2024
@clydin clydin merged commit c685c70 into angular:main Nov 25, 2024
34 checks passed
@clydin
Copy link
Member

clydin commented Nov 25, 2024

The changes were merged into the following branches: main, 19.0.x

@alan-agius4 alan-agius4 deleted the ssg-legacy branch November 25, 2024 20:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails in Angular SSR application with route parameters
2 participants