Skip to content

fix(keyboardSupport): Prevent losing focus when slider is rerendered #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

ValentinH
Copy link
Member

@ValentinH
Copy link
Member Author

@dagerikhl Can I have your feedback pls?

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #415 into master will not change coverage

@@           master   #415   diff @@
====================================
  Files           1      1          
  Lines         854    862     +8   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits          854    862     +8   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 8af6174...e77d91a

@dagerikhl
Copy link

I can confirm that the proposed solution fixes the problem seamlessly, thanks a lot!
The issue seems to have completely vanished, and the fix is as far as I can see optimal.

In response to your comment on the issue: #411 (comment)

You are correct in that it did not completely lose focus. It still appeared focused, and kept the blue square focus-indicator, but it could not be moved by using keys until it was purposely deselected and reselected.

This was on Google Chrome 53.0.2785.116 m.

Once again, thanks for being so helpful!

@ValentinH
Copy link
Member Author

Great, then I merge it and will bump a new version.

@ValentinH ValentinH merged commit 8cbdc46 into master Sep 22, 2016
@ValentinH ValentinH deleted the fix-411-issue branch October 16, 2016 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants