Fix test failures and deprecated Pillow functions #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dataymeric How far until this branch is merged? Thanks You |
|
Sorry for the slow response, I pushed to the branch to trigger CI, which should be fine, now? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #709 : It appeared tests were failing because of now deprecated
np.intused in the creation of masks. It has been changed tointto avoid failures.Fixes #685 #705 : as mentionned, some Pillow functions were soon deprecated, which were
textsize()andgetsize(). They have been changed to their counterparttextbbox()andgetbbox().I also looked at the deprecated
plt.cm.get_cmap()but as of now, I am not sure how to deal with it. We should usematplotlib.colormaps[name]ormatplotlib.colormaps.get_cmap(obj), but the first only deals with strings and the latter is not available in Python 3.7.