Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Don't assign variable name back to wordcloud #466

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

shuttle1987
Copy link
Contributor

Improve example code to not overwrite the wordcloud name

@amueller
Copy link
Owner

Thanks. It's not really overwriting anything because the name wordcloud is not defined in that scope, but you're right, not using it is more clear.

@amueller amueller merged commit d674088 into amueller:master Jan 28, 2019
@shuttle1987
Copy link
Contributor Author

I was using this library today in a workshop from within jupyter, someone copied and pasted from the example and this caused some confusion when later code broke. Thanks for the great library!

@amueller
Copy link
Owner

amueller commented Jan 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants